Use .to eq consistently
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several older tests still had `.to eql("foo")` while most tests used
`.to eq "foo"`. We'll prefer the short, plain version and keep the
parentheses as needed for comparing hashes.
|
Thanks for cleaning this up! Small cleanup PRs separate from other changes are always welcome. |
iMacTia
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several older tests still had
.to eql("foo")while most tests used.to eq "foo". We'll prefer the short, plain version and keep the parentheses as needed for comparing hashes.Additional Notes
I generally prefer this sort of cleanup to be separate from other changes, but I understand you might prefer to include cleanup when touching files as part of a separate change in functionality.