Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Small bug fixes in librelinkup and futher improvements to carelink #17

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

AndyLow91
Copy link
Member

This still is not working exactly as expected, but no longer returns the authorization error when using librelinkup.

fixed path for trace-axios dependency
Bug found - "var connections = resp.data.data;"
This was not a bug afterall, reverting.
Typo found in "opts.linkUpPatientId;"
@AndyLow91
Copy link
Member Author

@bewest I've added some further changes tonight, which will hopefully resolve the stale pump data alarm shown when using the carelink connection. It was difficult to fully test this in my dev environment, so please if you can test it out that would be great!

@AndyLow91 AndyLow91 changed the title Some Small bug fixes in librelinkup Some Small bug fixes in librelinkup and futher improvements to carelink Aug 9, 2023
@bewest
Copy link
Member

bewest commented Aug 14, 2023

Updated to share the same code to adjust treatments (dateTime vs datetime) as well in #19

@AndyLow91
Copy link
Member Author

Medtronic have made another breaking change to their european servers over the last few days, updating the user-agent string in the http header request appears to have solved this. @bewest - If you can merge, that would be awesome!

@bewest
Copy link
Member

bewest commented Aug 18, 2023

Could you please test if it's needed on fewer endpoints, eg only the ones that absolutely require an html/js engine?
If it does not work, could you please try adding the nightscout-connect@version string somewhere inside the longer UA string? I think it's important that we deny Medtronic the pleasure of plausible deniability and provide traceability back to the source code when there are issues.

@bewest bewest merged commit b03f358 into nightscout:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants