Fix updating valhalla.json after changes in valhalla configuration

[mlidodo]

After changes done in valhalla/valhalla#5010, the scripts/configure_valhalla.json cannot update valhalla.json anymore:

jq: error: syntax error, unexpected LITERAL, expecting end of file (Unix shell quoting issues?) at <top-level>, line 1:
.thor.costmatrix.hierarchy_limits.max_up_transitions.1 | if type == "null" then false else true end                                                    

The reason is that when retrieving value of a key using jq, where a component of the key is a number in string:

"bidirectional_astar": {
    "hierarchy_limits": {
        "max_up_transitions": {
            "1": 400,
            "2": 100,
        },
        "expand_within_distance": {"0": 1e8, "1": 20000, "2": 5000},
    }
}

The issue is in the loop, which retrieves all keys from valhalla.json:

docker-valhalla/scripts/configure_valhalla.sh

Lines 127 to 135 in 78e9259

	jq -r 'paths | select(map(type) | index("number") | not ) | "." + join(".")' ${TMP_CONFIG_FILE} | while read key ; do
	# if the key path does not exist in the existing config
	jq -e "${key} | if type == \"null\" then false else true end" ${CONFIG_FILE} >/dev/null
	if [ $? -eq 1 ]; then
	# get its value from the temp config
	newval=$(jq "${key}" ${TMP_CONFIG_FILE})
	echo "INFO: copied new config entry ${key}=${newval} into existing config."

I was able to fix the expression by transforming the keys into object index syntax (instead of the object identifier-index syntax), it should look like this:

paths(scalars | true) | select(map(type) | index("number") | not ) | [.[] | ".[\"\(.)\"]"] | join("")

The generated keys now look like this:

.["thor"].["bidirectional_astar"].["hierarchy_limits"].["expand_within_distance"].["0"]
.["thor"].["bidirectional_astar"].["hierarchy_limits"].["expand_within_distance"].["1"]
.["thor"].["bidirectional_astar"].["hierarchy_limits"].["expand_within_distance"].["2"]
.["thor"].["bidirectional_astar"].["hierarchy_limits"].["max_up_transitions"].["1"]
.["thor"].["bidirectional_astar"].["hierarchy_limits"].["max_up_transitions"].["2"]

With these, jq is now able to retrieve the values correctly:

100000000.0
20000
5000
400
100

[chrstnbwnkl]

Ah yes thank you! I feared this was going to happen with the config updates... I'll try to get this merged soon.

test failure