Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7] [iOS] Setup CD: Firebase #49

Merged
merged 3 commits into from
Jan 2, 2024
Merged

[#7] [iOS] Setup CD: Firebase #49

merged 3 commits into from
Jan 2, 2024

Conversation

phongvhd93
Copy link
Collaborator

@phongvhd93 phongvhd93 commented Nov 24, 2023 •
edited
Loading

What happened 👀

Created 2 job for distribute the app to Firebase (Staging) and TestFlight (Production)

Insight 📝

Add jobs to two workflows for deploy iOS app to Firebase (staging) and TestFlight (production)

  • deploy_staging
  • deploy_production

Proof Of Work 📹

Deploy Staging Build
Screenshot 2023-12-18 at 09 23 56

Deploy Production Build

Screenshot 2023-12-18 at 09 20 39

@phongvhd93 phongvhd93 added this to the 0.3.0 milestone Nov 24, 2023
@phongvhd93 phongvhd93 self-assigned this Nov 24, 2023
@phongvhd93 phongvhd93 marked this pull request as draft November 24, 2023 01:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

9 Warnings
⚠️ Big PR
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ android/src/main/java/co/nimblehq/kmm/template/ui/screens/home/HomeScreen.kt#L66 - This expression contains a magic number. Consider defining it to a well named constant.
⚠️ shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
⚠️ shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt#L18 - Exception is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
⚠️ shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
⚠️ shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: 59.92%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

Gemfile.lock
Podfile.lock
deploy_production.yml
deploy_production.yml
deploy_staging.yml
deploy_staging.yml
project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

1 Warning
⚠️ This pull request is quite big (683 lines changed), please consider splitting it into multiple pull requests.

Current coverage for sample is 18.25%

✅ No files affecting coverage found

Powered by xcov

Generated by 🚫 Danger

@lydiasama lydiasama force-pushed the feature/6-set-up-cd-android branch 3 times, most recently from 9fb4a89 to cf3cd8a Compare November 24, 2023 10:26
@phongvhd93 phongvhd93 force-pushed the feature/7-set-up-cd-ios branch from 0e61b1d to d29e8c3 Compare November 27, 2023 07:29
@phongvhd93 phongvhd93 force-pushed the feature/7-set-up-cd-ios branch from 108d4c9 to deb5dfe Compare November 27, 2023 07:57
@lydiasama lydiasama force-pushed the feature/6-set-up-cd-android branch from cf3cd8a to 44b9129 Compare November 30, 2023 03:20
@lydiasama lydiasama force-pushed the feature/6-set-up-cd-android branch from e632f8f to 8a2d1a2 Compare November 30, 2023 10:53
@luongvo luongvo force-pushed the feature/6-set-up-cd-android branch from 8a2d1a2 to a8e761b Compare November 30, 2023 10:53
@luongvo luongvo mentioned this pull request Nov 30, 2023
Merged
2 tasks
@luongvo luongvo force-pushed the feature/6-set-up-cd-android branch from 9067f94 to 9651dc9 Compare November 30, 2023 11:13
Base automatically changed from feature/6-set-up-cd-android to develop December 1, 2023 08:52
@phongvhd93 phongvhd93 force-pushed the feature/7-set-up-cd-ios branch from f0b27a3 to e79131b Compare December 15, 2023 07:30
@phongvhd93 phongvhd93 marked this pull request as ready for review December 15, 2023 07:41
@phongvhd93 phongvhd93 marked this pull request as draft December 15, 2023 07:42
@phongvhd93 phongvhd93 force-pushed the feature/7-set-up-cd-ios branch from 948df1f to b3dbf2d Compare December 15, 2023 07:46
@phongvhd93 phongvhd93 force-pushed the feature/7-set-up-cd-ios branch from e869071 to f40607a Compare December 18, 2023 02:17
@phongvhd93 phongvhd93 marked this pull request as ready for review December 18, 2023 02:27
@phongvhd93 phongvhd93 requested a review from luongvo December 18, 2023 02:27
@phongvhd93 phongvhd93 force-pushed the feature/7-set-up-cd-ios branch from 777ff76 to b5bf810 Compare December 18, 2023 02:58
@phongvhd93 phongvhd93 requested a review from lydiasama December 21, 2023 02:37
luongvo
luongvo approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@luongvo
Copy link
Member

luongvo commented Dec 26, 2023

@phongvhd93 please request reviews & complete this task soon 🙏

@phongvhd93 phongvhd93 merged commit 4e0c6d5 into develop Jan 2, 2024
@phongvhd93 phongvhd93 deleted the feature/7-set-up-cd-ios branch January 2, 2024 02:23
@phongvhd93 phongvhd93 mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luongvo luongvo luongvo approved these changes

@markgravity markgravity markgravity approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK is a code owner

@kaungkhantsoe kaungkhantsoe Awaiting requested review from kaungkhantsoe kaungkhantsoe is a code owner

@lydiasama lydiasama Awaiting requested review from lydiasama

Assignees

@phongvhd93 phongvhd93

Labels
type : feature
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

[iOS] Setup CD: Firebase
5 participants
@phongvhd93 @luongvo @lydiasama @markgravity @bot-nimble