Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf(resources): Use acres over vendored data loader #3323

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

effigies
Copy link
Member

Created https://github.com/nipreps/acres based on fMRIPrep's data loader, to help avoid getting out-of-sync.

Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@effigies
Copy link
Member Author

RTD failure is unrelated. Will look into that separately.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.68%. Comparing base (19201db) to head (73d7ea8).
Report is 101 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3323      +/-   ##
==========================================
- Coverage   73.85%   73.68%   -0.18%     
==========================================
  Files          56       56              
  Lines        4272     4233      -39     
==========================================
- Hits         3155     3119      -36     
+ Misses       1117     1114       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 8d0f433 into nipreps:master Jul 16, 2024
16 of 17 checks passed
@effigies effigies deleted the rf/acres branch July 16, 2024 18:28
effigies added a commit that referenced this pull request Sep 16, 2024
24.1.0 (September 16, 2024)

New feature release in the 24.1.x series.

Handling of gradient echo fieldmaps is improved.

  * FIX: Select volumetric dseg.tsv from recent TemplateFlow releases (#3257)
  * RF: Adapt to less T1w-centric smriprep (#3333)
  * RF: Use acres over vendored data loader (#3323)
  * DOC: Add benchmark page (#3312)
  * MAINT: Move to tox to simplify test/CI setup (#3326)
  * CI: Fix expected outputs for fieldmaps (#3321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants