Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf(py314): Replace deprecated pkgutil.find_loader #3384

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 16, 2024

This PR removes pkgutil.find_loader() and replaces it with importlib.util.find_spec(). find_loader was deprecated in Python 3.12 and will be removed in 3.14. find_spec has been present since Python 3.4.

Both functions return None if the module loader cannot be found. For its use in this project, this is sufficient and no translation of the return value is needed.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.06%. Comparing base (5d7a6d3) to head (bf38d9e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
fmriprep/cli/parser.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3384   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files          57       57           
  Lines        4231     4231           
  Branches      456      455    -1     
=======================================
  Hits         3049     3049           
  Misses       1067     1067           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 2e4f921 into master Oct 16, 2024
17 of 19 checks passed
@effigies effigies deleted the rf/drop-pkgutil-find_loader branch October 16, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant