Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Ensure fieldmap is resampled correctly in report #3387

Merged
merged 3 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,27 +1,36 @@
24.1.2 (To be determined)
=========================
Bug fix release in the 24.1.x series.

* FIX: Ensure fieldmap is resampled correctly in report (#3387)


24.1.1 (October 10, 2024)
=========================
Bug fix release in the 24.1.x series.

Precomputed functional derivatives were not being correcly detected,
and a couple fixes for rare issues.

* FIX: Remove checks for unit zooms and symmetric rotations in template warp (#3376)
* FIX: Stop excluding FS minc_modify_header used during fallback registration (#3372)
* FIX: Repair search for precomputed bold references (#3370)
* FIX: Repair search for precomputed transforms (#3369)
* FIX: Remove checks for unit zooms and symmetric rotations in template warp (#3376)
* FIX: Stop excluding FS minc_modify_header used during fallback registration (#3372)
* FIX: Repair search for precomputed bold references (#3370)
* FIX: Repair search for precomputed transforms (#3369)


24.1.0 (September 16, 2024)
===========================
New feature release in the 24.1.x series.

Handling of gradient echo fieldmaps is improved.

* FIX: Select volumetric dseg.tsv from recent TemplateFlow releases (#3257)
* RF: Adapt to less T1w-centric smriprep (#3333)
* RF: Use acres over vendored data loader (#3323)
* DOC: Add benchmark page (#3312)
* MAINT: Move to tox to simplify test/CI setup (#3326)
* CI: Fix expected outputs for fieldmaps (#3321)
* FIX: Select volumetric dseg.tsv from recent TemplateFlow releases (#3257)
* RF: Adapt to less T1w-centric smriprep (#3333)
* RF: Use acres over vendored data loader (#3323)
* DOC: Add benchmark page (#3312)
* MAINT: Move to tox to simplify test/CI setup (#3326)
* CI: Fix expected outputs for fieldmaps (#3321)


24.0.1 (July 16, 2024)
======================
Expand Down
25 changes: 20 additions & 5 deletions fmriprep/workflows/bold/outputs.py
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,26 @@ def init_func_fit_reports_wf(
mem_gb=1,
)

fmap_boldref = pe.Node(
ApplyTransforms(
dimension=3,
default_value=0,
float=True,
invert_transform_flags=[True],
interpolation='LanczosWindowedSinc',
),
name='fmap_boldref',
mem_gb=1,
)

# SDC1
sdcreg_report = pe.Node(
FieldmapReportlet(
reference_label='BOLD reference',
moving_label='Fieldmap reference',
show='both',
),
name='sdecreg_report',
name='sdcreg_report',
mem_gb=0.1,
)

Expand Down Expand Up @@ -360,19 +372,23 @@ def init_func_fit_reports_wf(
name='ds_sdc_report',
)

# fmt:off
workflow.connect([
(inputnode, fmapref_boldref, [
('fmap_ref', 'input_image'),
('coreg_boldref', 'reference_image'),
('boldref2fmap_xfm', 'transforms'),
]),
(inputnode, fmap_boldref, [
('fieldmap', 'input_image'),
('coreg_boldref', 'reference_image'),
('boldref2fmap_xfm', 'transforms'),
]),
(inputnode, sdcreg_report, [
('sdc_boldref', 'reference'),
('fieldmap', 'fieldmap'),
('bold_mask', 'mask'),
]),
(fmapref_boldref, sdcreg_report, [('output_image', 'moving')]),
(fmap_boldref, sdcreg_report, [('output_image', 'fieldmap')]),
(inputnode, ds_sdcreg_report, [('source_file', 'source_file')]),
(sdcreg_report, ds_sdcreg_report, [('out_report', 'in_file')]),
(inputnode, sdc_report, [
Expand All @@ -382,8 +398,7 @@ def init_func_fit_reports_wf(
(boldref_wm, sdc_report, [('output_image', 'wm_seg')]),
(inputnode, ds_sdc_report, [('source_file', 'source_file')]),
(sdc_report, ds_sdc_report, [('out_report', 'in_file')]),
])
# fmt:on
]) # fmt:skip

# EPI-T1 registration
# Resample T1w image onto EPI-space
Expand Down