-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: adapt code so it works with different versions of networkx #1137
Conversation
e5c42e8
to
4f58bbd
Compare
4f58bbd
to
cf681a2
Compare
@esavary @oesteban GitHub action build (3.11, pip==21.2) complains there is no space left on the device. Is there something that should be done at the organization level to solve this issue?
PS as it also fails on PR #1140 it seems more likely the problem is GitHub action itself than my code. |
try: | ||
self.refidx[self.refidx[:, jobid].nonzero()[0], jobid] = 0 | ||
except NotImplementedError: | ||
self.refidx[self.refidx[:, [jobid]].nonzero()[0], jobid] = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this addressing? Is there an issue open for this failure condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I changed l. 351, MRIQC was running into a NotImplementedError because they did not implement the feature for 1D arrays. Sorry, I cannot find again the exact error message so I don't remember which software was issuing the error. But, the error message suggested this workaround.
Since this looks like mostly a copy from nipype, it might be best just to copy what we did in nipype: nipy/nipype@443492e |
Hello @celprov, Thank you for updating!
To test for issues locally, Comment last updated at 2023-09-19 17:56:05 UTC |
e8b0c85
to
cf681a2
Compare
Thanks @effigies for the suggestion. I implemented it in the last commit. |
fix: Resolve dependency issue with newer version of networkx
Closes #1136