Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCKER: Include 3T18yoSchwartzReactN32 FreeSurfer atlas in image #357

Merged
merged 2 commits into from
Aug 16, 2023
Merged

DOCKER: Include 3T18yoSchwartzReactN32 FreeSurfer atlas in image #357

merged 2 commits into from
Aug 16, 2023

Conversation

psadil
Copy link
Contributor

@psadil psadil commented Aug 16, 2023

Closes #356

@effigies
Copy link
Member

The failures seem to be related to a weird issue we had in fmriprep about sort suddenly working oddly. We'll need to update the machine images in CircleCI.

@psadil
Copy link
Contributor Author

psadil commented Aug 16, 2023

Oh I see -- thanks for clarifying

@effigies
Copy link
Member

Here's the commit, if you want to try replicating it here: nipreps/fmriprep@6fd7c54

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +22.99% 🎉

Comparison is base (4f3723b) 31.08% compared to head (22a230f) 54.07%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #357       +/-   ##
===========================================
+ Coverage   31.08%   54.07%   +22.99%     
===========================================
  Files          20       22        +2     
  Lines        1454     1459        +5     
  Branches      206      206               
===========================================
+ Hits          452      789      +337     
+ Misses        987      614      -373     
- Partials       15       56       +41     
Flag Coverage Δ
ds005 ∅ <ø> (?)
ds054 44.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psadil
Copy link
Contributor Author

psadil commented Aug 16, 2023

Here's hoping "here" meant in this pull request 😅 Let me know if I should break off that last commit into another pull request or issue

@effigies effigies enabled auto-merge (squash) August 16, 2023 19:20
@effigies effigies merged commit 8cca75a into nipreps:master Aug 16, 2023
12 checks passed
@effigies
Copy link
Member

Perfect. Thanks!

@psadil psadil deleted the fix/keep-3T18yoSchwartzReactN32 branch August 16, 2023 22:19
effigies added a commit that referenced this pull request Aug 17, 2023
0.12.2 (August 16, 2023)

Bug-fix release in the 0.12.x series.

In rare cases where Freesurfer is unable to align to its default atlas in
Talairach registration, it was unable to fall back to the Schwartz atlas
because we were not including it in the Docker image. This release exists
to provide an updated Docker image, and no upgrade is needed for users not
encountering this issue.

* DOCKER: Include 3T18yoSchwartzReactN32 FreeSurfer atlas in image (#357)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include 3T18yoSchwartzReactN32 in Docker
2 participants