-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add Multimodal Surface Matching #358
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
===========================================
- Coverage 54.03% 33.67% -20.37%
===========================================
Files 22 21 -1
Lines 1488 1574 +86
Branches 209 212 +3
===========================================
- Hits 804 530 -274
- Misses 628 1029 +401
+ Partials 56 15 -41
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I'm able to follow this so far. Is there more to go, or was the FNIRT stuff a red herring? |
No, it looks like those are still to come (see below), though I'm not sure if it should be included here or in a separate PR. Steps
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. One small comment.
Follow-up to #358 in smriprep-next. This continues to save the initial `space-fsLR_desc-reg_sphere.surf.gii` and adds `space-fsLR_desc-msm_sphere.surf.gii`.
Closes #353.