Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Begin testing on Python 3.12 #1247

Merged
merged 6 commits into from
Sep 19, 2023
Merged

CI: Begin testing on Python 3.12 #1247

merged 6 commits into from
Sep 19, 2023

Conversation

effigies
Copy link
Member

@effigies effigies commented Aug 15, 2023

Numpy 1.26b1 is out, allowing tests on Python 3.12.

Not yet ready to test on numpy 2.0, so leaving the nightly build URLs as-is for now.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (5f37398) 92.16% compared to head (a42321f) 92.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
- Coverage   92.16%   92.15%   -0.02%     
==========================================
  Files          98       98              
  Lines       12371    12374       +3     
  Branches     2542     2542              
==========================================
+ Hits        11402    11403       +1     
- Misses        646      648       +2     
  Partials      323      323              
Files Changed Coverage Δ
nibabel/openers.py 93.10% <100.00%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

Well, looks like there are numeric issues, or possibly isinstance() or similar checks are now producing different results. Debugging locally seems tricky, as Python 3.12rc1 won't build with pyenv on Ubuntu 22.04. Will try a Docker image when I get a chance.

@effigies
Copy link
Member Author

Not a numeric issue, but gzip: python/cpython#108111

@effigies effigies merged commit 9c568dc into nipy:master Sep 19, 2023
45 of 46 checks passed
@effigies effigies deleted the ci/py312 branch September 19, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant