Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Replace dict literal with set() #1383

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

effigies
Copy link
Member

Thanks to @musicinmybrain for finding and reporting this.

Closes gh-1382.

@effigies
Copy link
Member Author

@musicinmybrain Does it make sense just to patch this for now? It does not seem entirely worth making a release for a bug in test code.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (7b5060e) to head (069942c).
Report is 2 commits behind head on maint/5.3.x.

Additional details and impacted files
@@               Coverage Diff               @@
##           maint/5.3.x    #1383      +/-   ##
===============================================
- Coverage        95.38%   95.37%   -0.01%     
===============================================
  Files              207      207              
  Lines            29672    29672              
  Branches          3018     3018              
===============================================
- Hits             28302    28300       -2     
- Misses             931      934       +3     
+ Partials           439      438       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@musicinmybrain
Copy link

I’m perfectly happy just to backport the patch until the next release, especially since it’s just a minor testing issue. If you give me about five minutes, I’ll test the patch in Fedora and report back.

@musicinmybrain
Copy link

Works for me! Thank you.

@effigies
Copy link
Member Author

@yurivict @penguinpee You're likely to hit this, too.

@TheChymera @sanjayankur31 @ashgillman Are you still packaging for Gentoo, CentOS and Nix? If so, let me know if a patch is okay or if you need a release. If not, can you @ your successors?

@effigies effigies merged commit 1b86af0 into maint/5.3.x Oct 25, 2024
39 of 40 checks passed
@effigies effigies deleted the fix/validator-classvar branch October 25, 2024 15:47
@musicinmybrain
Copy link

@TheChymera @sanjayankur31 @ashgillman Are you still packaging for Gentoo, CentOS and Nix? If so, let me know if a patch is okay or if you need a release. If not, can you @ your successors?

I’m assisting @sanjayankur31 with the Fedora package, which is how I encountered this. There is no corresponding EPEL package (which is how it would be made available to CentOS users). It’s probably possible to get it working there, but NeuroFedora packages are generally only added to EPEL at their primary maintainers’ discretion or upon request, rather than by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants