adding status token to fix badge error #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vsoch <[email protected]>
|
usually the token is not necessary (in nipype we simply have this: does it have something to do with the publicness of circle and to which repo/user it's connected to? |
|
@satra I think that's probably correct. I don't think it's me!
Do we know who originally made the connection to circle? |
|
well some magic happened. i set this project to free and open source and it looks like i can see the badge. i don't know who connected it though. perhaps we can close this and delete the api key for the badge and see what happens? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the token is scoped to "status" so I don't think it can be used maliciously (and is intended for putting in a repo). Thoughts? I had thought this only was relevant for private repos, but it seems to be the case here. This will close #63
Signed-off-by: vsoch [email protected]