Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Build wheels with limited API #210

Closed
wants to merge 2 commits into from
Closed

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 11, 2023

Inspired by @vstinner's PyCon slides, I wanted to see if we could build to the Python limited API, which allows a single wheel to support all versions of Python above some minimum.

I've collapsed the build matrix down, and added a broad test matrix to ensure that the built wheels work correctly. This will produce fewer wheels (one per-platform) that should be installable on Python 3.13 as soon as Numpy has a build out.

Once this is in, I can stop pestering you with updates to the build system.

I'm using https://github.com/joerick/python-abi3-package-sample/ as a guide.

@arokem
Copy link
Member

arokem commented Oct 31, 2023

I have to say that I am not 100% sure what's going on here. Is there any reason you can see not to merge this?

@effigies
Copy link
Member Author

I had another look at this, and I think the tests may be passing because of the fallback version of tridisolve, and not because we can successfully compile this to the ABI. Closing for now.

@effigies effigies closed this Oct 31, 2023
@effigies effigies deleted the mnt/abi3 branch October 31, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants