Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Missing Person Details #63

Closed

Conversation

viharpatel94
Copy link

No description provided.

@gauravmittal1995
Copy link
Collaborator

There seems to be some indentation error. Try setting it to similar indentation.

Also file modes are getting changed. @nisargjhaveri Does it matter?

Have'nt tried it yet, will do it tom

@gauravmittal1995
Copy link
Collaborator

Also you need to remove merge commits. Instead of merging, try rebasing.

@imjalpreet
Copy link
Collaborator

It is still not complete as when we click on update the form I got had empty fields even if there was data already in those fields in the db. For eg in my case the section Contact details of missing person was empty. If you need some kind of template you can have a look at #59 's update function.

@nisargjhaveri
Copy link
Owner

Also, as @gauravmittal1995 mentioned, file modes should not be changed as 644 is good enough, there is not need to give execute permission on PHP files.

@gauravmittal1995
Copy link
Collaborator

To be completed in #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants