Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support formations and vessels #31

Merged
merged 4 commits into from
Jul 19, 2024
Merged

feat: support formations and vessels #31

merged 4 commits into from
Jul 19, 2024

Conversation

nrwiersma
Copy link
Collaborator

This adds support for Formations in the provider.

@nrwiersma nrwiersma requested a review from Ullaakut July 19, 2024 07:33
@nrwiersma nrwiersma self-assigned this Jul 19, 2024
@nrwiersma nrwiersma changed the title feat: support Formations feat: support formations and vessels Jul 19, 2024
Ullaakut
Ullaakut approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks

ec/formation/resource_formation_test.go Outdated Show resolved Hide resolved
ec/formation/resource_vessel.go Outdated Show resolved Hide resolved
ec/formation/resource_vessel_test.go Outdated Show resolved Hide resolved
@nrwiersma nrwiersma merged commit 8a79538 into main Jul 19, 2024
1 check passed
@nrwiersma nrwiersma deleted the formations branch July 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ullaakut Ullaakut Ullaakut approved these changes

Assignees

@nrwiersma nrwiersma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrwiersma @Ullaakut