Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use exsolve for module resolution #3125

Merged
merged 6 commits into from
Feb 25, 2025
Merged

perf: use exsolve for module resolution #3125

merged 6 commits into from
Feb 25, 2025

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 25, 2025

This PR uses resolve utils from exsolve which have improved performances.

Additional extensions and suffixes have to be kept to avoid breaking behavior change but still perf should be better.

modulesDir option is also normalized with trailing slashes to allow search path fast-path (could be better with file:// URL but nothing significant for now)

@pi0 pi0 marked this pull request as draft February 25, 2025 12:13
@pi0 pi0 changed the title perf: use exsolve for resolver perf: use exsolve for module resolution Feb 25, 2025
@pi0 pi0 marked this pull request as ready for review February 25, 2025 13:32
@pi0 pi0 merged commit 2ab3e58 into v2 Feb 25, 2025
4 checks passed
@pi0 pi0 deleted the perf/exsolve branch February 25, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant