Replace inout parameter by proper return type

nitroshare · Mar 16, 2021 · 2f4c694 · 2f4c694
1 parent 7af1ac0
commit 2f4c694
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/include/qmdnsengine/dns.h b/src/include/qmdnsengine/dns.h
@@ -107,9 +107,9 @@ QMDNSENGINE_EXPORT bool fromPacket(const QByteArray &packet, Message &message);
 /**
  * @brief Create a raw DNS packet from a Message
  * @param message Message to create the packet from
- * @param packet storage for raw DNS packet
+ * @return packet storage for raw DNS packet
  */
-QMDNSENGINE_EXPORT void toPacket(const Message &message, QByteArray &packet);
+QMDNSENGINE_EXPORT QByteArray toPacket(const Message &message);
 
 /**
  * @brief Retrieve the string representation of a DNS type

diff --git a/src/src/dns.cpp b/src/src/dns.cpp
@@ -335,8 +335,9 @@ bool fromPacket(const QByteArray &packet, Message &message)
     return true;
 }
 
-void toPacket(const Message &message, QByteArray &packet)
+QByteArray toPacket(const Message &message)
 {
+    QByteArray packet;
     quint16 offset = 0;
     quint16 flags = (message.isResponse() ? 0x8400 : 0) |
         (message.isTruncated() ? 0x200 : 0);
@@ -357,6 +358,7 @@ void toPacket(const Message &message, QByteArray &packet)
     for (Record record : records) {
         writeRecord(packet, offset, record, nameMap);
     }
+    return packet;
 }
 
 QString typeName(quint16 type)

diff --git a/src/src/server.cpp b/src/src/server.cpp
@@ -141,8 +141,7 @@ Server::Server(QObject *parent)
 
 void Server::sendMessage(const Message &message)
 {
-    QByteArray packet;
-    toPacket(message, packet);
+    const auto packet = toPacket(message);
     if (message.address().protocol() == QAbstractSocket::IPv4Protocol) {
         d->ipv4Socket.writeDatagram(packet, message.address(), message.port());
     } else {
@@ -152,8 +151,7 @@ void Server::sendMessage(const Message &message)
 
 void Server::sendMessageToAll(const Message &message)
 {
-    QByteArray packet;
-    toPacket(message, packet);
+    const auto packet = toPacket(message);
     d->ipv4Socket.writeDatagram(packet, MdnsIpv4Address, MdnsPort);
     d->ipv6Socket.writeDatagram(packet, MdnsIpv6Address, MdnsPort);
 }