nix-bundle.sh: Modernize CLI #48
Conversation
TODOs: * [ ] Update `README.md` * [ ] What about `nix2appimage.sh`?
haslersn
force-pushed
the
enhancement/modern-cli
branch
from
809f99d to
14157e0
Compare
|
Can somebody please explain to me what |
The idea is you can put multiple paths into a tarball. For instance you might want to add |
nix-bundle.sh
Outdated
| nix build "${build_flags[@]}" "$target" || exit $? | ||
| if [ -z "$target_path" ] | ||
| then | ||
| target_path="$(readlink "$linkdir/result")" |
There was a problem hiding this comment.
How does this handle multiple targets?
There was a problem hiding this comment.
extra_target_paths contains the store paths (separated by whitespace) to the extra targets.
|
|
||
| expr="(with import $nix_file {}; $bootstrap { target = $target_path; extraTargets = [$extra_target_paths ]; run = \"$bin\"; })" | ||
|
|
||
| echo $expr | ||
|
|
||
| out=$(nix-store --no-gc-warning -r $(nix-instantiate --no-gc-warning -E "$expr")) |
There was a problem hiding this comment.
This should normally do the actual build, The hope is that it avoids creating /result dirs in the user's directory.
There was a problem hiding this comment.
Although it's not clear how to handle some of the new flags like -f, etc. nix-instantiate does allow --arg and --argstr however.
There was a problem hiding this comment.
nix build has nicer output and it allows to use the modern nix cli. The result link is created in a temporary directory.
|
@edolstra added some handling for "app"s which have a "program" attr. NixOS/nix#2909. I am not sure if we can use that effectively here, since it is still unreleased. |
…LE or default
Previously, they were just taken from the `import <nixpkgs> {}` inside `./default.nix`.
Possible solution to #47.
TODOs:
README.mdnix2appimage.sh?