Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue a warning if we are falling back to the old shell environment #487

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Issue a warning if we are falling back to the old shell environment #487

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9d3a36
Issue a warning if we fallback to the old shell
bbenne10 Apr 19, 2024
b653b72
Add shellcheck to the devshell
bbenne10 Apr 19, 2024
aa50e0f
Set NIX_DIRENV_DID_FALLBACK where appropriate
bbenne10 Apr 19, 2024
ba0cf20
Update tests to expect new output strings
bbenne10 Apr 19, 2024
a69341c
Update README
bbenne10 Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions direnvrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ use_flake() {
# which is probably more useful than nothing.
# Fallback to use that (which means just leaving profile_rc alone!)
_nix_direnv_warning "Evaluating current devShell failed. Falling back to previous environment!"
export NIX_DIRENV_DID_FALLBACK=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is the consumer of this environment variable?

fi
fi
else
Expand Down Expand Up @@ -479,6 +480,7 @@ use_nix() {
_nix_direnv_info "Renewed cache"
else
_nix_direnv_warning "Evaluating current nix shell failed. Falling back to previous environment!"
export NIX_DIRENV_DID_FALLBACK=1
fi
fi
else
Expand Down
Loading