Fix incorrect posix_spawn* error checking #2513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The posix_spawn functions do not use `-1` as the sentinel for errors, rather `0` is return on success and every other return value is an error. Adds a test case to test posix_spawn failure.
|
Thanks for catching it! |
|
Hi, I recently hit this issue and fixed it myself (because I forgot about this PR, sorry 🤦♂️) |
|
Close as this is superseded by #2595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The posix_spawn functions do not use
-1as the sentinel for errors,rather
0is return on success and every other return value is anerror.
Adds a test case to test posix_spawn failure.
Checklist:
CONTRIBUTING.md