Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative paths #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mateusz-olczyk
Copy link

  • We're using cwd=tmpdir.name in try_configure() for higher compatibility because -B <path-to-build> was added in CMake version 3.13. This however leads to unexpected results when we pass relative paths as arguments because such paths become relative to the temporary directory, not cwd of shell.
  • tools_directory containing CMake downloaded binaries is by default created relatively to current working directory instead of being placed in the root directory of the repository which would make more sense.

Thanks to the proposed changes the following call becomes possible:

cd ~/projects
❯ ~/cmake_min_version/cmake_min_version.py example

Make "tools" directory placed always inside the script directory, not
current working directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant