fix: add max query delay validation per data source

manifest/v1alpha/agent/validation.go

@@ -37,7 +37,7 @@ var specValidation = govy.New[Spec](
 		Rules(exactlyOneDataSourceTypeValidationRule).
 		Rules(
 			historicalDataRetrievalValidationRule,
-			queryDelayGreaterThanOrEqualToDefaultValidationRule),
+			queryDelayValidationRule),
 	govy.For(func(s Spec) v1alpha.ReleaseChannel { return s.ReleaseChannel }).
 		WithName("releaseChannel").
 		OmitEmpty().
@@ -239,8 +239,8 @@ var (
 )
 
 const (
-	errCodeExactlyOneDataSourceType              = "exactly_one_data_source_type"
-	errCodeQueryDelayGreaterThanOrEqualToDefault = "query_delay_greater_than_or_equal_to_default"
+	errCodeExactlyOneDataSourceType = "exactly_one_data_source_type"
+	errCodeQueryDelayOutOfBounds    = "query_delay_out_of_bounds"
 )
 
 var exactlyOneDataSourceTypeValidationRule = govy.NewRule(func(spec Spec) error {
@@ -420,11 +420,23 @@ var historicalDataRetrievalValidationRule = govy.NewRule(func(spec Spec) error {
 	return nil
 })
 
-var queryDelayGreaterThanOrEqualToDefaultValidationRule = govy.NewRule(func(spec Spec) error {
+var queryDelayValidationRule = govy.NewRule(func(spec Spec) error {
 	if spec.QueryDelay == nil {
 		return nil
 	}
 	typ, _ := spec.GetType()
+	maxQueryDelay := v1alpha.GetQueryDelayMax(typ)
+	maxQueryDelayAllowed := v1alpha.Duration{
+		Value: maxQueryDelay.Value,
+		Unit:  maxQueryDelay.Unit,
+	}
+	if spec.QueryDelay.Duration.GreaterThan(maxQueryDelayAllowed) {
+		return govy.NewPropertyError(
+			"queryDelay",
+			spec.QueryDelay,
+			errors.Errorf("must be less than or equal to %d %s",
+				*maxQueryDelayAllowed.Value, maxQueryDelayAllowed.Unit))
+	}
 	agentDefault := v1alpha.GetQueryDelayDefaults()[typ]
 	if spec.QueryDelay.LessThan(agentDefault) {
 		return govy.NewPropertyError(
@@ -434,7 +446,7 @@ var queryDelayGreaterThanOrEqualToDefaultValidationRule = govy.NewRule(func(spec
 		)
 	}
 	return nil
-}).WithErrorCode(errCodeQueryDelayGreaterThanOrEqualToDefault)
+}).WithErrorCode(errCodeQueryDelayOutOfBounds)
 
 // newURLValidator is a helper construct for Agent which only have a simple 'url' field govy.
 func newURLValidator[S any](getter govy.PropertyGetter[string, S]) govy.Validator[S] {

manifest/v1alpha/agent/validation_test.go

@@ -179,16 +179,29 @@ func TestValidateSpec_QueryDelay(t *testing.T) {
 			})
 		}
 	})
-	t.Run("delay larger than max query delay", func(t *testing.T) {
+	t.Run("delay larger than default max query delay", func(t *testing.T) {
 		agent := validAgent(v1alpha.Prometheus)
+
 		agent.Spec.QueryDelay = &v1alpha.QueryDelay{Duration: v1alpha.Duration{
 			Value: ptr(1441),
 			Unit:  v1alpha.Minute,
 		}}
 		err := validate(agent)
 		testutils.AssertContainsErrors(t, agent, err, 1, testutils.ExpectedError{
-			Prop:    "spec.queryDelay",
-			Message: "must be less than or equal to 1440m",
+			Prop: "spec.queryDelay",
+			Code: errCodeQueryDelayOutOfBounds,
+		})
+	})
+	t.Run("delay larger than data source max query delay", func(t *testing.T) {
+		agent := validAgent(v1alpha.SplunkObservability)
+		agent.Spec.QueryDelay = &v1alpha.QueryDelay{Duration: v1alpha.Duration{
+			Value: ptr(16),
+			Unit:  v1alpha.Minute,
+		}}
+		err := validate(agent)
+		testutils.AssertContainsErrors(t, agent, err, 1, testutils.ExpectedError{
+			Prop: "spec.queryDelay",
+			Code: errCodeQueryDelayOutOfBounds,
 		})
 	})
 	t.Run("delay less than default", func(t *testing.T) {
@@ -203,7 +216,7 @@ func TestValidateSpec_QueryDelay(t *testing.T) {
 				err := validate(agent)
 				testutils.AssertContainsErrors(t, agent, err, 1, testutils.ExpectedError{
 					Prop: "spec.queryDelay",
-					Code: errCodeQueryDelayGreaterThanOrEqualToDefault,
+					Code: errCodeQueryDelayOutOfBounds,
 				})
 			})
 		}