feat: Update Honeycomb config to forbid raw metrics; support good total single query only [PC-15396] #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s; added validation for raw metrics - forbidden
bdw-nobl9
force-pushed
the
PC-15396-support-only-hc-single-query
branch
from
dce0c48 to
a74b722
Compare
bdw-nobl9
changed the title
bdw-nobl9
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
dawidwisn
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
lgtm! We are waiting for those changes: https://github.com/nobl9/n9/pull/16773
nikodemrafalski
commented
Feb 5, 2025
bdw-nobl9
approved these changes
Feb 24, 2025
bdw-nobl9
added a commit
to nobl9/terraform-provider-nobl9
that referenced
this pull request
Feb 27, 2025
## Summary The PR comments code the invocating `test-honeycomb` test case to avoid failing acceptance tests by the unsupported version of the Honeycomb contract that's included in those tests. ## Related changes [SDK](nobl9/nobl9-go#633) ## Testing - Run acceptance tests or check the results of running them [here](https://github.com/nobl9/terraform-provider-nobl9/actions/runs/13554457376/job/37885574234).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changed the way we support Honeycomb integration - now only ratio (countMetrics) SLOs are available, using only
COUNTcalculation method. Raw (threshold) metrics are forbidden, which is tested by validation.Summary
Unsupported ways of configuring Honeycomb data sources were removed, and the validation checking metric type (only ratios are allowed) was introduced.