Skip to content

Commit

Permalink
lookup: declare bankruptcy on flaky modules
Browse files Browse the repository at this point in the history
Remove all modules that failed the latest 20.x release run. We need to
be able to trust that a failed CITGM run is something that needs to be
investigated.
  • Loading branch information
Trott committed Sep 7, 2023
1 parent 460c3a0 commit a8b18ae
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 168 deletions.
166 changes: 2 additions & 164 deletions lib/lookup.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,6 @@
"skip": ["win32", "14"],
"maintainers": "dominictarr"
},
"acorn": {
"maintainers": "marijnh",
"skip": ["win32", "ppc"]
},
"async": {
"prefix": "v",
"maintainers": ["aearly", "megawac"]
},
"ava": {
"prefix": "v",
"skip": ["14", "ppc", "win32", "x86", "rhel", "aix", "ia32"],
"maintainers": ["sindresorhus", "novemberborn"]
},
"bcrypt": {
"prefix": "v",
"tags": "native",
Expand Down Expand Up @@ -81,25 +68,13 @@
"scripts": ["test-node"],
"skip": true
},
"bufferutil": {
"prefix": "v",
"tags": "native",
"maintainers": ["3rdeden", "einaros", "lpinca"],
"skip": "win32"
},
"cheerio": {
"skip": ["aix", "win32"],
"head": true,
"useGitClone": true,
"maintainers": ["matthewmueller", "jugglinmike"],
"scripts": ["test:jest"]
},
"clinic": {
"maintainers": "mcollina",
"flaky": ["rhel"],
"prefix": "v",
"skip": ["aix", "win32"]
},
"coffeescript": {
"maintainers": ["jashkenas", "GeoffreyBooth"],
"skip": ["rhel", "aix"]
Expand Down Expand Up @@ -135,14 +110,6 @@
"prefix": "v",
"maintainers": "mafintosh"
},
"ember-cli": {
"envVar": { "YARN_IGNORE_ENGINES": "true" },
"prefix": "v",
"flaky": ["win32", "rhel", "sles"],
"head": true,
"expectFail": "fips",
"maintainers": ["stefanpenner", "rwjblue", "Turbo87", "kellyselden"]
},
"end-of-stream": {
"prefix": "v",
"maintainers": "mafintosh",
Expand All @@ -161,19 +128,10 @@
"expectFail": "fips",
"skip": ["win32"]
},
"express": {
"flaky": "ppc",
"maintainers": "dougwilson",
"skip": "win32"
},
"express-session": {
"prefix": "v",
"maintainers": "dougwilson"
},
"fastify": {
"maintainers": ["mcollina", "delvedor"],
"prefix": "v"
},
"flush-write-stream": {
"prefix": "v",
"maintainers": "mafintosh",
Expand Down Expand Up @@ -222,10 +180,6 @@
"maintainers": "contra",
"skip": "win32"
},
"https-proxy-agent": {
"maintainers": "TooTallNate",
"scripts": ["build", "test"]
},
"iconv": {
"prefix": "v",
"flaky": "aix",
Expand All @@ -243,23 +197,14 @@
},
"is-core-module": {
"prefix": "v",
"skip": "win32",
"maintainers": "ljharb",
"scripts": ["tests-only"]
},
"isarray": {
"prefix": "v",
"maintainers": "juliangruber"
},
"jest": {
"prefix": "v",
"maintainers": ["cpojer", "scotthovestadt", "SimenB", "thymikee", "jeysal"],
"yarn": true,
"install": ["install", "--no-immutable"],
"scripts": ["build:js", "remove-examples", "test-ci-partial"],
"envVar": { "CI": true },
"skip": ["aix", "s390x", "ppc", "darwin", "win32"],
"timeout": 1800000
},
"jose": {
"maintainers": ["panva"],
"prefix": "v",
Expand All @@ -284,13 +229,6 @@
"maintainers": ["ralphtheninja", "vweevers"],
"skip": "win32"
},
"leveldown": {
"prefix": "v",
"useGitClone": true,
"flaky": ["ppc", "s390"],
"tags": "native",
"maintainers": ["ralphtheninja", "vweevers"]
},
"libxmljs": {
"prefix": "v",
"flaky": ["aix", "sles", "rhel", "darwin"],
Expand All @@ -310,17 +248,9 @@
"skip": "aix",
"comment": "Marked as flaky on win32 due to this issue https://github.com/nodejs/citgm/issues/930"
},
"microtime": {
"prefix": "v",
"tags": "native",
"maintainers": "wadey"
},
"mime": {
"prefix": "v",
"maintainers": "broofa"
},
"minimist": {
"npm": true,
"skip": "win32",
"maintainers": "substack"
},
"mkdirp": {
Expand All @@ -339,18 +269,6 @@
"maintainers": "ichernev",
"skip": [true, "ppc", "s390"]
},
"multer": {
"prefix": "v",
"skip": "win32",
"maintainers": "linusu"
},
"nan": {
"maintainers": ["nodejs/addon-api"],
"prefix": "v",
"scripts": ["rebuild-tests", "test"],
"tags": "native",
"head": true
},
"node-gyp": {
"envVar": { "FAST_TEST": "true" },
"prefix": "v",
Expand All @@ -365,24 +283,11 @@
"comment": "Flaky because of test timeouts",
"skip": true
},
"npm": {
"maintainers": ["nodejs/npm"],
"prefix": "v",
"skip": ["aix", "s390"]
},
"path-to-regexp": {
"prefix": "v",
"maintainers": "blakeembrey",
"skip": ["aix"]
},
"pino": {
"prefix": "v",
"maintainers": "mcollina"
},
"prom-client": {
"prefix": "v",
"maintainers": ["siimon", "zbjornson", "SimenB"]
},
"pug": {
"prefix": "pug@",
"yarn": true,
Expand All @@ -391,11 +296,6 @@
"comment": "Error message changes in V8 9.3",
"repo": "https://github.com/pugjs/pug"
},
"pump": {
"prefix": "v",
"maintainers": "mafintosh",
"skip": "win32"
},
"pumpify": {
"prefix": "v",
"maintainers": "mafintosh",
Expand Down Expand Up @@ -429,20 +329,6 @@
"maintainers": "ljharb",
"scripts": ["tests-only", "posttest"]
},
"rewire": {
"prefix": "v",
"maintainers": "jhnns"
},
"rimraf": {
"prefix": "v",
"flaky": "win32",
"maintainers": "isaacs"
},
"router": {
"prefix": "v",
"maintainers": "dougwilson",
"skip": "win32"
},
"sax": {
"skip": "win32",
"prefix": "v",
Expand All @@ -457,25 +343,12 @@
"envVar": { "npm_config_ignore_scripts": "true" },
"comment": "postlint script fails"
},
"serialport": {
"prefix": "serialport@",
"flaky": ["ppc", "rhel"],
"tags": "native",
"maintainers": "reconbot",
"skip": ["win32"]
},
"socket.io": {
"maintainers": "rauchg",
"head": true,
"skip": ">=17",
"comment": "WS is not compatible"
},
"spawn-wrap": {
"prefix": "v",
"flaky": ["sles", "aix", "darwin"],
"maintainers": "isaacs",
"skip": "win32"
},
"spdy": {
"prefix": "v",
"flaky": ["aix", "sles"],
Expand Down Expand Up @@ -505,11 +378,6 @@
"maintainers": "tj",
"skip": ">=11"
},
"tape": {
"head": true,
"prefix": "v",
"maintainers": "substack"
},
"thread-sleep": {
"install": ["install", "--build-from-source"],
"tags": "native",
Expand All @@ -528,35 +396,13 @@
"stripAnsi": true,
"maintainers": "mcollina"
},
"torrent-stream": {
"prefix": "v",
"maintainers": "mafintosh"
},
"tough-cookie": {
"maintainers": ["awaterma", "colincasey", "ruoho", "wjharney"]
},
"uglify-js": {
"prefix": "v",
"flaky": ["ppc", "darwin"],
"maintainers": "mishoo",
"skip": ["12", true],
"comment": "Tests timeout"
},
"underscore": {
"flaky": ["aix", "s390"],
"skip": "win32",
"maintainers": "jashkenas",
"ignoreGitHead": true
},
"undici": {
"prefix": "v",
"maintainers": ["mcollina", "ronag"]
},
"uuid": {
"prefix": "v",
"maintainers": ["ctavan", "broofa"],
"skip": ["win32", "aix"]
},
"vinyl": {
"prefix": "v",
"maintainers": ["contra", "phated"],
Expand All @@ -579,14 +425,6 @@
"maintainers": "tootallnate",
"tags": "native"
},
"winston": {
"flaky": ["win32", "ppc", "s390", "darwin"],
"maintainers": "indexzero"
},
"ws": {
"expectFail": "fips",
"maintainers": ["einaros", "3rd-Eden", "lpinca"]
},
"yargs": {
"comment": "Install from source is currently broken due to TS error",
"prefix": "v",
Expand Down
5 changes: 1 addition & 4 deletions test/test-lookup.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@ test('lookup[getLookupTable]:', (t) => {
});
t.ok(table, 'table should exist');
t.ok(table.lodash, 'lodash should be in the table');
t.ok(
table.underscore.maintainers,
'underscore should contain a maintainers parameter'
);
t.ok(table.weak.maintainers, 'weak should contain a maintainers parameter');
t.end();
});

Expand Down

0 comments on commit a8b18ae

Please sign in to comment.