test: execute shell directly for refresh() #55051
Open
+19
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
avivkeller
reviewed
Sep 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55051 +/- ##
=======================================
Coverage 89.13% 89.14%
=======================================
Files 665 665
Lines 193165 193179 +14
Branches 37191 37196 +5
=======================================
+ Hits 172181 172204 +23
- Misses 13729 13730 +1
+ Partials 7255 7245 -10 |
|
cc @nodejs/cpp-reviewers @nodejs/tsc would you mind reviewing? |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
I don't really have a strong opinion on it. The code change looks fine but not sure if it's worthwhile or not. @nodejs/testing folks? |
|
I expect problems in windows, but if we can get it to pass on CI it's ok. |
This PR doesn't update Windows implementation. Only UNIX |
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Jan 24, 2025
aduh95
reviewed
Jan 24, 2025
aduh95
reviewed
Jan 24, 2025
aduh95
reviewed
Jan 25, 2025
anonrig
force-pushed
the
call-rm-directly
branch
2 times, most recently
from
682b29e to
f03ece3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Feb 9, 2025
aduh95
reviewed
Feb 9, 2025
test/common/tmpdir.js
Outdated
| @@ -5,17 +5,27 @@ const fs = require('fs'); | |||
| const path = require('path'); | |||
| const { pathToFileURL } = require('url'); | |||
| const { isMainThread } = require('worker_threads'); | |||
| const isUnixLike = process.platform !== 'win32'; | |||
| const { escapePOSIXShell } = require('./index.js'); | |||
There was a problem hiding this comment.
Looks like you need to lazy load to workaround the circular dependency
anonrig
force-pushed
the
call-rm-directly
branch
from
f03ece3 to
5888bc2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What if we just called the shell directly to avoid the cost of booting a Node.js instance?
cc @nodejs/build any concerns?