test: fix race condition in test-child-process-bad-stdio #56845
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Jan 31, 2025
jasnell
approved these changes
Jan 31, 2025
cjihrig
added
the
commit-queue-squash
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56845 +/- ##
=======================================
Coverage 89.16% 89.17%
=======================================
Files 665 665
Lines 192602 192602
Branches 37052 37058 +6
=======================================
+ Hits 171743 171746 +3
- Misses 13668 13671 +3
+ Partials 7191 7185 -6 |
test-child-process-bad-stdio.js contains a race condition between a timeout in the test process and a timeout in the spawned child process. This commit addresses the race condition by having the child process wait indefinitely to be killed.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jakecastelli
approved these changes
Feb 3, 2025
jakecastelli
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 793c793 |
targos
pushed a commit
that referenced
this pull request
Feb 5, 2025
test-child-process-bad-stdio.js contains a race condition between a timeout in the test process and a timeout in the spawned child process. This commit addresses the race condition by having the child process wait indefinitely to be killed. PR-URL: #56845 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-child-process-bad-stdio.js contains a race condition between a timeout in the test process and a timeout in the spawned child process. This commit addresses the race condition by having the child process wait indefinitely to be killed.
I was unable to reproduce the race condition locally using the test as it was originally written (I ran a 1,000 iteration stress test). I was able to reproduce it by tweaking the timeout duration in the parent process, which leads me to believe this was due to some slowness in the CI.