Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unnecessary syscall to cpuinfo #56968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: remove unnecessary syscall to cpuinfo #56968

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 8, 2025

Before this PR, we made a sys call to /proc/cpuinfo even if we don't need it... let's improve our test runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 8, 2025
@anonrig anonrig force-pushed the yagiz/reduce-fs-calls branch from 6cf2fca to 73f90e0 Compare February 8, 2025 22:15
@anonrig anonrig requested review from jasnell and cjihrig February 8, 2025 22:15
@anonrig anonrig force-pushed the yagiz/reduce-fs-calls branch from 73f90e0 to a29d7d3 Compare February 8, 2025 22:20
@codecov Codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (b181535) to head (a29d7d3).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56968   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files         665      665           
  Lines      193165   193165           
  Branches    37191    37191           
=======================================
+ Hits       172181   172182    +1     
+ Misses      13729    13726    -3     
- Partials     7255     7257    +2

see 25 files with indirect coverage changes

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 9, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/65081/ 💛

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @nodejs-github-bot @jasnell @lpinca @targos @cjihrig @jakecastelli