Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: improve error handling in string_bytes/decoder #56978

Merged
merged 1 commit into from
Feb 11, 2025
Merged

src: improve error handling in string_bytes/decoder #56978

merged 1 commit into from
Feb 11, 2025
+25 −25

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 9, 2025

Replace ToLocalChecked uses

@jasnell jasnell requested review from anonrig and legendecas February 9, 2025 16:36
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 9, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Feb 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.12%. Comparing base (d1f8ccb) to head (d970140).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/string_bytes.cc 85.71% 0 Missing and 2 partials ⚠️
src/string_decoder.cc 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56978      +/-   ##
==========================================
- Coverage   89.13%   89.12%   -0.02%     
==========================================
  Files         665      665              
  Lines      193167   193170       +3     
  Branches    37190    37183       -7     
==========================================
- Hits       172185   172165      -20     
- Misses      13731    13732       +1     
- Partials     7251     7273      +22
Files with missing lines Coverage Δ
src/string_decoder.cc 91.75% <88.88%> (+0.12%) ⬆️
src/string_bytes.cc 68.43% <85.71%> (ø)

... and 22 files with indirect coverage changes

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 9, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/65104/ 💛

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit cbedcd1 into nodejs:main Feb 11, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cbedcd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @anonrig @legendecas