Skip to content

Commit

Permalink
chore: add warning for adding new git dependencies in deny.toml (#4255
Browse files Browse the repository at this point in the history
)

# Description

## Problem\*

Related to #4247

## Summary\*

This PR adds a big nasty warning for adding new git dependencies as part
of avoiding #4247 happening again.

## Additional Context

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
TomAFrench authored Feb 5, 2024
1 parent fab4a6e commit ccdfbcf
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ unknown-registry = "warn"
# Lint level for what to happen when a crate from a git repository that is not
# in the allow list is encountered
unknown-git = "deny"

# DON'T YOU DARE ADD ANYTHING TO THIS IF YOU WANT TO PUBLISH ANYTHING NOIR RELATED TO CRATES.IO
#
# crates.io rejects git dependencies so anything depending on these is unpublishable and you'll ruin my day
# when I find out.
allow-git = [
"https://github.com/noir-lang/grumpkin",
"https://github.com/jfecher/chumsky"
Expand Down

0 comments on commit ccdfbcf

Please sign in to comment.