Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brillig function call isn't properly covered by a manual constraint when using println #7577

Open
jfecher opened this issue Mar 4, 2025 · 2 comments · May be fixed by #7644
Open

Brillig function call isn't properly covered by a manual constraint when using println #7577

jfecher opened this issue Mar 4, 2025 · 2 comments · May be fixed by #7644
Assignees
@rkarabut
Labels
bug Something isn't working
Milestone
1.0

Comments

@jfecher
Copy link
Contributor

jfecher commented Mar 4, 2025

Aim

fn main() {
    println(3);
}

Expected Behavior

3 to be printed out. No errors, warnings, or bugs.

Bug

bug: Brillig function call isn't properly covered by a manual constraint
   ┌─ std/lib.nr:43:9
   │
43 │         print_unconstrained(true, input);
   │         -------------------------------- This Brillig call's inputs and its return values haven't been sufficiently constrained. This should be done to prevent potential soundness vulnerabilities
   │
   = Call stack:
     1. src/main.nr:2:5
     2. std/lib.nr:43:9

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@jfecher jfecher added the bug Something isn't working label Mar 4, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 4, 2025
@asterite
Copy link
Collaborator

asterite commented Mar 5, 2025

Might be a duplicate of #6793

@TomAFrench TomAFrench added this to the 1.0 milestone Mar 5, 2025
@TomAFrench
Copy link
Member

@rkarabut Can you take a look at this? I'm not sure why this warning would be shown given we're not returning any new values in the circuit.

@rkarabut rkarabut linked a pull request Mar 10, 2025 that will close this issue
Open
5 tasks
@rkarabut rkarabut linked a pull request Mar 10, 2025 that will close this issue
fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) #7644
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkarabut rkarabut

Labels
bug Something isn't working
Projects
Noir
Status: 📋 Backlog
Milestone
1.0
4 participants
@asterite @rkarabut @jfecher @TomAFrench