Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) #7644

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) #7644

wants to merge 3 commits into from
+32 −0

Conversation

rkarabut
Copy link
Contributor

Description

Problem*

Resolves #7577

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@rkarabut rkarabut self-assigned this Mar 10, 2025
@rkarabut rkarabut linked an issue Mar 10, 2025 that may be closed by this pull request
Brillig function call isn't properly covered by a manual constraint when using println #7577
Open
@rkarabut rkarabut requested review from aakoshh and TomAFrench March 10, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakoshh aakoshh Awaiting requested review from aakoshh

@TomAFrench TomAFrench Awaiting requested review from TomAFrench

At least 1 approving review is required to merge this pull request.

Assignees

@rkarabut rkarabut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brillig function call isn't properly covered by a manual constraint when using println
1 participant
@rkarabut