-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(fmt): fix emit comments #3406
Conversation
can you write a description to say what is being fixed here and or open up an issue? |
Is this correct? It comments out the contract uniswap part |
Aht the test is not actually doing that though |
fn hello() {
1; // 42
2
}
fn hello() {
1;
// 42
2
} Is this what we want? I'd think we'd always want to keep the comment on the same line unless it's prohibitively long at least: fn hello() {
1; // 42
2
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of this PR is misleading/incorrect but the expected tests look good to me.
I wrote in the problems section, this is how it was formatted before. but found other problems - moved them to draft |
Co-authored-by: kevaundray <[email protected]>
Description
Problem
pre
post:
pre
post:
// lalalalalalalal contract Uniswap {}
Additional Context
Documentation
Check one:
PR Checklist*
cargo fmt
on default settings.