New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify `field_less_than` in stdlib #6993

Closed

TomAFrench wants to merge 1 commit into master from tf/remove-wrapper-for-field-less-than

Member

TomAFrench commented Jan 8, 2025

Description

Problem*

Resolves

Summary*

Not sure why we have this wrapper so seeing if we can just remove it.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.


          chore: simplify field_less_than in stdlib

93652fc

Contributor

github-actions bot commented Jan 8, 2025

Compilation Memory Report

Program	Peak Memory	%
keccak256	78.54M	0%
workspace	123.40M	0%
regression_4709	422.95M	0%
ram_blowup_regression	1.58G	0%
rollup-base-public	1.93G	-50%
rollup-base-private	914.32M	100%
private-kernel-tail	200.39M	0%
private-kernel-reset	728.13M	0%
private-kernel-inner	254.74M	-13%

Contributor

github-actions bot commented Jan 8, 2025

Execution Memory Report

Program	Peak Memory	%
keccak256	74.63M	0%
workspace	123.66M	0%
regression_4709	422.95M	33%
ram_blowup_regression	512.40M	0%
rollup-base-public	1.93G	100%
rollup-base-private	914.32M	175%
private-kernel-tail	181.07M	0%
private-kernel-reset	254.93M	0%
private-kernel-inner	254.74M	19%

Member Author

TomAFrench commented Jan 8, 2025

I guess that's why.

TomAFrench closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet