Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark division/modulo by constants as not requiring a predicate #7028

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

We should be able to deduplicate divisions by non-zero constants.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Jan 11, 2025

Compilation Memory Report

Program Peak Memory
keccak256 78.13M
workspace 123.47M
regression_4709 424.09M
ram_blowup_regression 1.58G
rollup-base-public 4.85G
rollup-base-private 1.26G
private-kernel-tail 207.14M
private-kernel-reset 669.12M
private-kernel-inner 294.37M

Copy link
Contributor

github-actions bot commented Jan 11, 2025

Execution Memory Report

Program Peak Memory
keccak256 74.67M
workspace 123.76M
regression_4709 316.00M
ram_blowup_regression 512.61M
rollup-base-public 479.46M
rollup-base-private 325.85M
private-kernel-tail 180.43M
private-kernel-reset 245.32M
private-kernel-inner 208.69M

Copy link
Contributor

github-actions bot commented Jan 11, 2025

Compilation Report

Program Compilation Time %
sha256_regression 1.248s -3%
regression_4709 0.785s -2%
ram_blowup_regression 18.060s -1%
rollup-root 3.354s -6%
rollup-block-merge 3.486s -1%
rollup-base-public 41.200s -6%
rollup-base-private 12.960s -3%
private-kernel-tail 0.962s -10%
private-kernel-reset 7.004s -1%
private-kernel-inner 2.024s -5%

Copy link
Contributor

github-actions bot commented Jan 11, 2025

Execution Report

Program Execution Time %
sha256_regression 0.051s 0%
regression_4709 0.001s 0%
ram_blowup_regression 0.629s -1%
rollup-root 0.104s -1%
rollup-block-merge 0.105s -1%
rollup-base-public 1.224s -1%
rollup-base-private 0.457s 0%
private-kernel-tail 0.019s -6%
private-kernel-reset 0.316s -2%
private-kernel-inner 0.071s 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant