Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent overlapping associated types impls #7047

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jan 13, 2025

Description

Problem*

Resolves #6811

Summary*

This was fairly straightforward

Additional Context

Documentation*

Check one:

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from a team January 13, 2025 20:00
Copy link
Contributor

Execution Memory Report

Program Peak Memory
keccak256 74.67M
workspace 123.46M
regression_4709 316.00M
ram_blowup_regression 512.61M
rollup-base-public 478.87M
rollup-base-private 325.48M
private-kernel-tail 180.47M
private-kernel-reset 245.16M
private-kernel-inner 208.55M

Copy link
Contributor

Compilation Memory Report

Program Peak Memory
keccak256 78.13M
workspace 123.89M
regression_4709 424.09M
ram_blowup_regression 1.58G
rollup-base-public 4.85G
rollup-base-private 1.26G
private-kernel-tail 207.18M
private-kernel-reset 669.26M
private-kernel-inner 294.40M

Copy link
Contributor

Compilation Report

Program Compilation Time %
sha256_regression 1.166s -12%
regression_4709 0.715s -12%
ram_blowup_regression 16.620s -10%
rollup-root 3.442s 0%
rollup-merge 1.808s 0%
rollup-block-merge 3.496s 3%
rollup-base-public 39.280s 0%
rollup-base-private 12.320s 0%
private-kernel-tail 1.032s -6%
private-kernel-reset 6.348s 0%
private-kernel-inner 2.230s 7%

Copy link
Contributor

Execution Report

Program Execution Time %
sha256_regression 0.050s -2%
regression_4709 0.001s 0%
ram_blowup_regression 0.555s -8%
rollup-root 0.104s 0%
rollup-merge 0.006s 0%
rollup-block-merge 0.104s -1%
rollup-base-public 1.212s -2%
rollup-base-private 0.450s -1%
private-kernel-tail 0.019s 0%
private-kernel-reset 0.311s -1%
private-kernel-inner 0.069s 1%

@TomAFrench TomAFrench enabled auto-merge January 13, 2025 20:13
@TomAFrench TomAFrench added this pull request to the merge queue Jan 20, 2025
Merged via the queue into master with commit ed9977a Jan 20, 2025
99 checks passed
@TomAFrench TomAFrench deleted the jf/stop-overlapping-impls branch January 20, 2025 17:39
TomAFrench added a commit that referenced this pull request Jan 20, 2025
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 21, 2025
…g/noir#7047)

feat: unconstrained optimizations for BoundedVec (noir-lang/noir#7119)
chore: mark libs good (noir-lang/noir#7123)
chore: remove comments for time/memory benchmarks (noir-lang/noir#7121)
fix: don't always use an exclusive lock in `nargo check` (noir-lang/noir#7120)
feat(ssa): Pass to preprocess functions (noir-lang/noir#7072)
chore: Formatting issues / minor errors in the docs (noir-lang/noir#7105)
fix: defunctionalize pass on the caller runtime to apply (noir-lang/noir#7100)
feat: Parser and formatter support for `enum`s (noir-lang/noir#7110)
feat(brillig): SSA globals code gen (noir-lang/noir#7021)
feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096)
chore: Add benchmarking dashboard (noir-lang/noir#7068)
feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088)
feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106)
chore: Cookbook Onboard integration (noir-lang/noir#7044)
chore: lock to ubuntu 22.04 (noir-lang/noir#7098)
fix: Remove unused brillig functions (noir-lang/noir#7102)
chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 21, 2025
feat: unconstrained optimizations for BoundedVec (noir-lang/noir#7119)
chore: mark libs good (noir-lang/noir#7123)
chore: remove comments for time/memory benchmarks (noir-lang/noir#7121)
fix: don't always use an exclusive lock in `nargo check` (noir-lang/noir#7120)
feat(ssa): Pass to preprocess functions (noir-lang/noir#7072)
chore: Formatting issues / minor errors in the docs (noir-lang/noir#7105)
fix: defunctionalize pass on the caller runtime to apply (noir-lang/noir#7100)
feat: Parser and formatter support for `enum`s (noir-lang/noir#7110)
feat(brillig): SSA globals code gen (noir-lang/noir#7021)
feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096)
chore: Add benchmarking dashboard (noir-lang/noir#7068)
feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088)
feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106)
chore: Cookbook Onboard integration (noir-lang/noir#7044)
chore: lock to ubuntu 22.04 (noir-lang/noir#7098)
fix: Remove unused brillig functions (noir-lang/noir#7102)
chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple impls of the same trait & object type allowed when the associated types or constants differ
3 participants