Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LSP autocomplete module declaration #7154

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

asterite
Copy link
Collaborator

@asterite asterite commented Jan 22, 2025

Description

Problem

No issue, just something that Rust Analyzer does but our current LSP doesn't.

Summary

Example for a "main" module:

lsp-complete-module-declaration

Example for a "non-main" module:

lsp-complete-module-declaration-2

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 7e5b0f3 Previous: 02056d6 Ratio
rollup-merge 2.426 s 1.972 s 1.23

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@asterite asterite requested a review from a team January 22, 2025 19:26
@TomAFrench TomAFrench added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit 1f1e750 Jan 22, 2025
101 checks passed
@TomAFrench TomAFrench deleted the ab/lsp-complete-module-declaration branch January 22, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants