feat(ssa): More aggressive Brillig loop unrolling #7236
+206
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 259b2ee | Previous: 0c6c637 | Ratio |
|---|---|---|---|
rollup-block-root |
4910 MB |
1230 MB |
3.99 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 259b2ee | Previous: 0c6c637 | Ratio |
|---|---|---|---|
noir-lang_schnorr_ |
1 s |
0 s |
+∞ |
noir-lang_noir_string_search_ |
1 s |
0 s |
+∞ |
noir-lang_mimc_ |
1 s |
0 s |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
Just a small improvement in execution speed then 😆 |
vezenovm
commented
Jan 30, 2025
tooling/nargo_cli/build.rs
Outdated
| @@ -198,8 +198,8 @@ fn test_{test_name}(force_brillig: ForceBrillig, inliner_aggressiveness: Inliner | |||
| nargo.arg("--force-brillig"); | |||
|
|
|||
| // Set the maximum increase so that part of the optimization is exercised (it might fail). | |||
| nargo.arg("--max-bytecode-increase-percent"); | |||
| nargo.arg("50"); | |||
| // nargo.arg("--max-bytecode-increase-percent"); | |||
There was a problem hiding this comment.
Noting that as we unroll more loops, this is potentially going to lead to panics. When we have a non-aggressive inliner the compiler is not going to have yet resolved certain intrinsics which we expect to be entirely known at compile-time (e.g. DerivePedersenGenerators).
|
This'll still be configurable via |
Do you mean Yes this will still be configurable. We will have to experiment a bit with what a good default target, as the changes definitely result in too-large of bytecode increases in some cases in my opinion. Right now we default to this flag not being set, although we do test for it in |
5 tasks
vezenovm
commented
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #7099
Summary*
Still a draft, needs lots of cleanup and tests, but I want to see the reports on CI.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.