Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This is an experimental branch where I'm hoping to fix the underlying issues with our usage of
dec_rc
. Currently this PR:dec_rc value original_value
back to a single valueddec_rc value
dec_rc
on parameters to always be issued on the original load value rather than creating a new load. This should fix the original underflow issue we changed dec_rc for.reference_counts
into a separate test for each inliner setting: min, 0, and max. The inliner0
setting was actually seeing different optimization characteristics compared to the other two just due to optimization ordering. The behavior is still correct though.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.