Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove some unused HIR code #7643

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: remove some unused HIR code #7643

wants to merge 2 commits into from
+3 −61

Conversation

asterite
Copy link
Collaborator

Description

Problem

I noticed this while working on #7613

Summary

Another thing I noticed is that HirExpression::Unquote is created here but I don't know if that should be HirExpression::Quoted (if so, HirExpression::Unquote could also be removed)

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite requested a review from a team March 10, 2025 14:54
michaeljklein
michaeljklein approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@michaeljklein michaeljklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Perhaps @jfecher knows why these became unused?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljklein michaeljklein michaeljklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asterite @michaeljklein