chore: Add option to set the aztec macros environment variable #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobyhallx
reviewed
Dec 4, 2023
| command, | ||
| args, | ||
| let serverOptions: ServerOptions = () => { | ||
| const env = aztecMacroEnabled ? { ...process.env, AZTEC_MACROS: 'true' } : { ...process.env }; |
There was a problem hiding this comment.
Please help me understand how this will affect LSP? Not obvious if this should affect version from master (I think yes, looking at the issue #52).
Also should this affect LSP only? If no, more lift is needed to support Command, Info and Profile commands.
|
Closing this as macros are on by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #52
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.