Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add linter setup #57

Merged
merged 4 commits into from
Dec 11, 2023
Merged

chore: add linter setup #57

merged 4 commits into from
Dec 11, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR adds the standard linter setup from the Noir monorepo.

As part of this I noticed that we weren't handling brillig opcodes in EditorLineDecorationManager which were hidden by not properly typing the functions. This results in no brillig opcodes being reported.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@socket-security Socket Security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@typescript-eslint/eslint-plugin 6.14.0 None +27 10.1 MB
eslint-plugin-prettier 5.0.1 None +54 6.2 MB jounqin
@typescript-eslint/parser 5.59.9...6.14.0 None +22/-22 7.11 MB
eslint 8.42.0...8.55.0 None +14/-13 5.2 MB eslintbot

🚮 Removed packages: [email protected]

@TomAFrench TomAFrench merged commit 74917a5 into master Dec 11, 2023
3 checks passed
@TomAFrench TomAFrench deleted the tf/linter-setup branch December 11, 2023 19:59
TomAFrench added a commit that referenced this pull request Dec 11, 2023
@TomAFrench
Merge branch 'master' into gj/format-on-save-default
a5dbe08 
* master:
  chore: add linter setup (#57)
  chore: run prettier (#56)
TomAFrench added a commit that referenced this pull request Dec 11, 2023
@TomAFrench
Merge branch 'master' into gj/format-on-save-default
df68b35 
* master:
  chore: add linter setup (#57)
  chore: run prettier (#56)
TomAFrench added a commit that referenced this pull request Dec 12, 2023
@TomAFrench
Merge branch 'master' into dap-support
d25f310 
* master:
  chore(ci): add check that extension will build on PRs (#58)
  chore: add linter setup (#57)
  chore: run prettier (#56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TomAFrench