Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docstrings to wiki_to_netflix.py #35

Closed
wants to merge 0 commits into from

Conversation

JamesKohlsRepo
Copy link
Collaborator

Main function still needs complete docstring. Requests in pipfle was changed to wildcard, we don't need to commit that change if we need that specific version

Copy link
Collaborator

@audiodude audiodude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Wow, very comprehensive, great job!

I would revert the Pipfile changes though, I already have #32 to loosen the requirements.

@audiodude
Copy link
Collaborator

Also you need to merge main so you get the workflow for ruff, which is required to merge. Once you have the workflow (in .github/workflows/ci), the ruff task will run and we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants