Update SerialPort to v10, fixing several breaking changes. I need a hand with tests. #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: This doesn't currently pass tests due to how SerialPort.list
gets mocked. I'm having a hard time understanding the correct way to
fix the mocking library.
SerialPort 10 is dramatically easier for Electron apps to bundle. I'd really love to get avrgirl-arduino updated to work with it.
Manual testing seems to indicate that the changes work, including the behaviour that's failing tests. It looks like there's a dep issue with avrga-tester that's blocking my ability to run through the test-pilot process. I'm really sorry about that :/
Signed-off-by: Jesse Vincent [email protected]
Description
Please review the contribution and code of conduct guidelines.
Please include a summary of the proposed improvement or addressed issue.
Fixes/addresses (If applicable) # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Test / Development Platform Information