Fix #4976. Node "Voronoi on Solid" produce incorrect results. #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update using Voronoi. Get new cells for border cells. - update parameter inset (now it use distance. Before was percent.)
portnov
reviewed
Aug 13, 2023
| ('MEAN', "Barycenter", "Scale each region relative to it's barycenter, i.e. average location of it's vertices", 1) | ||
| ] | ||
|
|
||
| scale_center : EnumProperty( |
There was a problem hiding this comment.
this is not used anymore as far as I understand?
There was a problem hiding this comment.
this is not used anymore as far as I understand?
Yes. It is not used more.
portnov
reviewed
Aug 13, 2023
|
|
||
| def draw_buttons_ext(self, context, layout): | ||
| self.draw_buttons(context, layout) | ||
| layout.prop(self, 'scale_center') |
portnov
reviewed
Aug 13, 2023
| layout.prop(self, 'scale_center') | ||
| layout.prop(self, 'accuracy') | ||
|
|
||
| def scale_cells(self, verts, sites, insets, precision): |
There was a problem hiding this comment.
fixed. scale_center removed.
portnov
reviewed
Aug 13, 2023
| y_min, y_max = box.YMin - clipping, box.YMax + clipping | ||
| z_min, z_max = box.ZMin - clipping, box.ZMax + clipping | ||
| bounds = list(itertools.product([x_min,x_max], [y_min, y_max], [z_min, z_max])) | ||
| verts, edges, faces = voronoi_on_mesh_bmesh(bounds, [ [0,1,3,2], [2,3,7,6], [6,7,5,4], [4,5,1,0], [2,6,4,0], [7,3,1,5] ], len(sites), sites, spacing=inset, mode='VOLUME' ) |
There was a problem hiding this comment.
numbers in brackets look magic :)
I'd suggest to assign them to a separate variable and add a comment about what is this.
There was a problem hiding this comment.
What brackets? If an argument for voronoi_on_mesh_bmesh then it is a cube faces that is a bounding box.
|
Description of fix:
|
satabol
force-pushed
the
fix_4976_node_voronoi_on_solid_produce_incorrect_result
branch
from
9f3875c
to
d17d373
Compare
|
now it's ok with me :) |
satabol
deleted the
fix_4976_node_voronoi_on_solid_produce_incorrect_result
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4976. Update node "Voronoi on Solid":
Description of fix:
Source algorithm of node "Voronoi on Solid" try to use closed cells of voronoi (1) for source sites but not all sites are closed. So old algorithm add bounding box points to sites (2):
This produce closed sites that was opened but this is produce some disturbing actions to source sites and some areas of bounding box are still opened. This can produce some glitches:
In other cases it can produce other glitches (view of Voronoi sites):
Result look unpredictable:
So I have a proposal:
Combine 1 and 2 with function voronoi_on_mesh_bmesh. Bounding box exceed solid bounding box for 1 in all directions:
and now results looks good.