Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Adding derivative-rodeo gem 🤠 #247

Merged
merged 1 commit into from
May 25, 2023

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented May 25, 2023

Why change < 4.0 to < 4? I was encountering issues where bundler was setting the dependency to hyrax v4.0.0.rc3. This change remedied that.

Why remove ~> 3.1 from rspec-rails dependency? I was getting issues with what version of Rails was required. By removing this hard dependency, we're able to let these gems sort things out.

Related to:

Why change `< 4.0` to `< 4`?  I was encountering issues where bundler
was setting the dependency to `hyrax v4.0.0.rc3`.  This change remedied
that.

Why remove `~> 3.1` from `rspec-rails` dependency?  I was getting issues
with what version of Rails was required.  By removing this hard
dependency, we're able to let these gems sort things out.

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/330
@jeremyf jeremyf merged commit 4544123 into main May 25, 2023
@jeremyf jeremyf deleted the incorporating-derivative_rodeo-without-faraday branch May 25, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants