Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul refactor the render codebase #20

Merged
merged 15 commits into from
Aug 5, 2024
Merged

Overhaul refactor the render codebase #20

merged 15 commits into from
Aug 5, 2024

Conversation

JarKz
Copy link
Contributor

@JarKz JarKz commented Jul 25, 2024

Main concept

The current state of the code is very difficult to maintain so need refactor for easing adding new features and detecting bugs. Here below a list of the actions which need to be done before merging to main branch. It can growth by new upcoming tasks.

Tasks

  • Add text ellipsis with new property
  • Add Draw trait with new type DrawColor and Coverage
  • Rewrite NotificationRect into BannerRect
  • Fix padding by combining with border size
  • Add helpful struct Offset for offsetting from top and left corners
  • Add image as table in config for margin
  • Add vertical and horizontal alignments for banner elements (i.e. texts, image)
  • Fix large memory allocation by fonts
  • Fix missing memory deallocation
  • Fix font issue about glyph layout (ab_glyph have something else than expected)
  • Implement Widgets and Containers like HPane/VPane for flexibility
  • Make more controlled wayland-client usage instead of rough actions

@JarKz JarKz force-pushed the overhaul-refactor branch 3 times, most recently from 878dfee to 96592a4 Compare July 30, 2024 07:50
@JarKz JarKz force-pushed the overhaul-refactor branch from 96592a4 to dc3314e Compare July 30, 2024 08:06
@JarKz JarKz force-pushed the overhaul-refactor branch from dc3314e to eb32871 Compare July 30, 2024 08:13
@JarKz
Copy link
Contributor Author

JarKz commented Aug 5, 2024

I think I'm done. The next commits must be in new MRs.

@JarKz JarKz marked this pull request as ready for review August 5, 2024 11:51
@JarKz JarKz merged commit f3aeb3e into main Aug 5, 2024
1 check passed
@JarKz JarKz deleted the overhaul-refactor branch August 6, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants