Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dev chains CI #148

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added dev chains CI #148

wants to merge 5 commits into from

Conversation

pgolovkin
Copy link
Collaborator

Added dev chains CI for collecting data and for deployment.

@pgolovkin pgolovkin requested a review from stepanLav September 29, 2022 16:09
exit $exit_code
shell: bash {0}

- uses: ./.github/workflows/deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it is the same action as for the main deployment
Isn't this version going to overlay the main version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the action is the same. It just builds the NPM package and updates the gh-pages. NPM is the same for dev and prod builds.
Thank you for noticing it. I missed it and it may cause a big problem. Lucky that deploy isn't environment dependent.

@pgolovkin pgolovkin requested a review from stepanLav October 3, 2022 12:22
@stepanLav
Copy link
Member

Found problem with deployment:

  • Cannot find module '../../public/data.json' from 'src/components/App.test.tsx'

run - https://github.com/nova-wallet/metadata-portal/actions/runs/3188326516

Screenshot 2022-10-05 at 14 49 20

@stepanLav stepanLav closed this Oct 5, 2022
@stepanLav stepanLav reopened this Oct 5, 2022
@pgolovkin
Copy link
Collaborator Author

Found problem with deployment:

  • Cannot find module '../../public/data.json' from 'src/components/App.test.tsx'

run - https://github.com/nova-wallet/metadata-portal/actions/runs/3188326516

Screenshot 2022-10-05 at 14 49 20

I'll work on it later. I don't know how to solve it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants