Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: storage facede #180

Merged
merged 3 commits into from
Mar 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions serpens/storages.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import importlib
import logging
import os
from enum import Enum
from typing import Any, Dict, Optional

logger = logging.getLogger(__name__)


class StorageProvider(Enum):
S3 = "s3"
CLOUD_STORAGE = "cloud_storage"


class StorageClient:
_instance = None

def __init__(self, provider: Optional[StorageProvider] = None):
self._provider = provider or StorageProvider(os.getenv("STORAGE_PROVIDER"))
logger.debug(f"Provider: {self._provider.value}")
module = importlib.import_module(f"serpens.{self._provider.value}")
self._get_object = module.get_object

def get(
self,
bucket: str,
key: str,
) -> Dict[str, Any]:
object = self._get_object(bucket, key)

return object

@classmethod
def instance(cls):
if cls._instance is None:
cls._instance = cls()
return cls._instance
24 changes: 24 additions & 0 deletions tests/test_storage.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import os
import unittest
from unittest.mock import patch

from serpens.storages import StorageClient


class TestStorages(unittest.TestCase):
def setUp(self):
self.patch_boto3 = patch("serpens.s3.boto3")
self.mock_boto3 = self.patch_boto3.start()
self.s3_client = self.mock_boto3.client.return_value

self.bucket = ""
self.key = ""

def tearDown(self):
self.patch_boto3.stop()

@patch.dict(os.environ, {"STORAGE_PROVIDER": "s3"})
def test_get_object_s3(self):
StorageClient.instance().get(self.bucket, self.key)

self.s3_client.get_object.assert_called_once_with(Bucket=self.bucket, Key=self.key)