Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sQpushBytes sending the beginning of the array multiple times #1892

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Fix sQpushBytes sending the beginning of the array multiple times #1892

merged 1 commit into from
Aug 29, 2024

Conversation

Bobini1
Copy link
Contributor

@Bobini1 Bobini1 commented Aug 23, 2024 •
edited
Loading

It turns out that pasting large amounts of text didn't work.

CendioOssman
CendioOssman approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We actually have a test for this, but apparently it was not a very good test. :/

@CendioOssman CendioOssman merged commit a446551 into novnc:master Aug 29, 2024
11 checks passed
@Bobini1 Bobini1 deleted the patch-1 branch August 30, 2024 10:56
@samhed samhed added the bug label Oct 3, 2024
@samhed samhed added this to the v1.6.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CendioOssman CendioOssman CendioOssman approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Bobini1 @CendioOssman @samhed